feat(console): deploy actions — + New fleet / + Add instance (slice 5/6) - #88
Merged
Merged
Conversation
ADR #83 §7.5: both entry points share the compose→preview→deploy engine (compose_library_get/compose_preview/deploy_provision), reached as an action from the Fleets (7.2) and Fleet detail (7.3) screens instead of sitting behind a standing tab. + New fleet runs a net-new fleet-identity step first (7.5.1); + Add instance skips straight to Compose, inheriting the fleet it was opened from (7.5.2). fleets.toml is only ever mutated after a confirmed successful provision (new src/fleetToml.ts, pure text-level append — fleet_config_write has no partial-write primitive, so both flows read-modify-write the full file client-side, per the ADR). The existing Compose tab (library authoring) is left in place — Part C also calls for dropping it once deploy is action-driven, but where template/overlay authoring moves to isn't decided in the ADR; punting that to the slice 7 self-review rather than deleting a working surface speculatively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice 5/6 of console-navigation-ia ADR (#83) — usercron
adr83-implrunbook, per §7.5.What
+ New fleet(Fleets screen, 7.2) and+ Add instance(Fleet detail, 7.3) now open a deploy panel instead of rendering disabled stubs.compose_library_get/compose_preview/deploy_provision), reused viacompose.ts's already-exported pure helpers — not reimplemented.+ New fleetruns a net-new fleet-identity step first (name/region/profile/principal — 7.5.1), then the same compose form.+ Add instanceskips straight to compose, inheriting the fleet it was opened from (7.5.2, no identity step).src/fleetToml.ts(pure, unit-tested): text-levelfleets.tomledits — append a member to an existing[fleet.<name>]block, or append a brand-new block.fleet_config_writehas no partial-write primitive, so both flows read-modify-write the full file client-side, per the ADR's own note.fleets.tomlis only touched after a confirmed successfuldeploy_provision— never before or speculatively.main.tsre-readsfleets.tomland either drills into the new fleet's detail screen or refreshes the active fleet's member filter in place.Scoping note
Part C of the ADR also says Compose should drop its permanent top-level tab once deploy is action-driven. I left the existing Compose tab (library/template/overlay authoring) in place — the ADR doesn't say where that authoring surface goes once the tab is gone, and removing a working feature without a documented replacement seemed worse than leaving it dual-reachable for now. Flagging for the slice 7 self-review rather than guessing.
Verification
tsc --noEmit— cleanvitest run— 106/106 passing (9 new forfleetToml.ts, 2 updated/added inrender.test.ts)vite build— clean🤖 Generated by Orca (
ecs-claude), usercronadr83-impl.